[NO MERGE] Release v2.4 rocm #334
Open
+4,460
−541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* tests drop Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move dir Signed-off-by: Pawel Gadzinski <[email protected]> * tests fox Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix Signed-off-by: Pawel Gadzinski <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Pawel Gadzinski <[email protected]> Signed-off-by: Przemek Tredak <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Przemek Tredak <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
* Fix README render on PyPI Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Update README.rst Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Use anonymous hyperlink for duplicate. Fix indent. Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
* Check tensor-recipe compatibility Signed-off-by: Evgeny Tsykunov <[email protected]> * Tensor class in recipe, checking for *Base Signed-off-by: Evgeny Tsykunov <[email protected]> * Extend recipe __repr__ with recipe_type Signed-off-by: Evgeny Tsykunov <[email protected]> * Warn about recipe change Signed-off-by: Evgeny Tsykunov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Enable dynamic recipe change: clear fp8 workspace Signed-off-by: Evgeny Tsykunov <[email protected]> * TE 1.x checkpoint compatibility Signed-off-by: Evgeny Tsykunov <[email protected]> * Disable warning for recipe wrappers Signed-off-by: Evgeny Tsykunov <[email protected]> * Test recipe change Signed-off-by: Evgeny Tsykunov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Use QuantizedTensorBase Signed-off-by: Evgeny Tsykunov <[email protected]> * Fix circular import Signed-off-by: Evgeny Tsykunov <[email protected]> * Revert previous circular import fix Signed-off-by: Evgeny Tsykunov <[email protected]> * Fix pytorch imports in common Signed-off-by: Evgeny Tsykunov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Let quantizer know about the recipe Signed-off-by: Evgeny Tsykunov <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fix imports Signed-off-by: Evgeny Tsykunov <[email protected]> --------- Signed-off-by: Evgeny Tsykunov <[email protected]> Signed-off-by: Kirthi Shankar Sivamani <[email protected]> Co-authored-by: Przemyslaw Tredak <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
…te (#1799) * Use an empty torch tensor to indicate no fp8 information in extra_state Signed-off-by: Peter St. John <[email protected]> * Add huggingface from_pretrained / save_pretrained tests Adds integration tests to ensure models containing TransformerLayer objects can be saved and loaded using the from_pretrained and save_pretrained methods. Signed-off-by: Peter St. John <[email protected]> --------- Signed-off-by: Peter St. John <[email protected]> Co-authored-by: Kirthi Shankar Sivamani <[email protected]>
…n (#1611) * docs drop Signed-off-by: Pawel Gadzinski <[email protected]> * a Signed-off-by: Pawel Gadzinski <[email protected]> * fix Signed-off-by: Pawel Gadzinski <[email protected]> * Update docs/debug/1_getting_started.rst Co-authored-by: Przemyslaw Tredak <[email protected]> Signed-off-by: Paweł Gadziński <[email protected]> * Update docs/debug/1_getting_started.rst Co-authored-by: Przemyslaw Tredak <[email protected]> Signed-off-by: Paweł Gadziński <[email protected]> * fixes Signed-off-by: Pawel Gadzinski <[email protected]> * fix imgs Signed-off-by: Pawel Gadzinski <[email protected]> --------- Signed-off-by: Pawel Gadzinski <[email protected]> Signed-off-by: Paweł Gadziński <[email protected]> Co-authored-by: Przemyslaw Tredak <[email protected]>
add docstring for CP Signed-off-by: Charlene Yang <[email protected]>
* Add missing docs for C API Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Grammar, typos, copy-paste errors Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * remove contiguous word Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Better wording Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Remove comm_gemm_overlap docs Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
Document all recipes Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
* Modify the test cases Signed-off-by: Przemek Tredak <[email protected]> * Make the tests reproducible on different machines Signed-off-by: Przemek Tredak <[email protected]> * Fixed the cache of the gamma_in_weight_dtype setting Signed-off-by: Przemek Tredak <[email protected]> * Reinstate the tests Signed-off-by: Przemek Tredak <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * More verbose code and comments Signed-off-by: Przemek Tredak <[email protected]> --------- Signed-off-by: Przemek Tredak <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Fix single FW build with multi FW available Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Some fixes Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * Fixes Signed-off-by: Kirthi Shankar Sivamani <[email protected]> * sug Signed-off-by: Kirthi Shankar Sivamani <[email protected]> --------- Signed-off-by: Kirthi Shankar Sivamani <[email protected]>
alextmagro
requested review from
ipanfilo,
wangye805 and
wenchenvincent
as code owners
wangye805
approved these changes
Oct 14, 2025
Collaborator
|
I think 1834247 should be also integrated |
…able_nccl_comm_splitting=false (#346)
* Fix MXFP8 GEMM test * Fix uninitialized var in GEMM code * Add Dequantize+GEMM test to check MXFP8 scaling tensor layout
* Build ROCm wheels directly from manylinix image * Fix build on top of the latest Manylinix image * Fix build after switching to AITER
* MXFP8 test scale off by 1 fix
(cherry picked from commit 6b8a47d)
(cherry picked from commit 9a987f8)
* AITER solib with commit fc3c0420 * [ROCm] api call fix and disable v3 fwd with swa (#331) * [ROCm] update aiter commit with gfx950 fix and swa fwd fix --------- Co-authored-by: Ye Wang <[email protected]> (cherry picked from commit b08a1ed)
(cherry picked from commit e9c7361)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release 2.4. Minor ROCm path changes for test_common.cu data generation to maintain stability across machines/compilers.